Update swift-rl to compile with modern S4TF toolchains. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
force-pushed
the
update-to-toolchain
branch
from
808d63b to
2f38379
Compare
There were some changes to the way derivatives are specified. Instead of specifying derivatives using `wrt`, the API has changed to use the `@derivative(of:)` syntax. Thanks to retroactive differentiability, we can simplify the code substantially and avoid the duplicate base method implementation.
saeta
force-pushed
the
update-to-toolchain
branch
from
2f38379 to
a2aa809
Compare
Owner
|
Thanks a lot for the PR Brennan! I'm sorry I somehow completely missed it. Is it still up-to-date with the current S4TF toolchain? |
Author
|
I believe so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some changes to the way derivatives are specified. Instead of
specifying derivatives using
wrt, the API has changed to use the@derivative(of:)syntax. Thanks to retroactive differentiability, we cansimplify the code substantially and avoid the duplicate base method
implementation.