Skip to content

Fixing crash on MP3 playback on ESP8266. #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2024
Merged

Fixing crash on MP3 playback on ESP8266. #723

merged 1 commit into from
Dec 25, 2024

Conversation

Misterke
Copy link
Contributor

This should fix the crash of issue #704 on ESP8266 on recent versions. At least it fixed it for my application.

@Misterke Misterke mentioned this pull request Dec 25, 2024
Closed
earlephilhower
earlephilhower approved these changes Dec 25, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! The 8266's weird 32b requirement and GCC's optimizer make for interesting issues like this.

@earlephilhower earlephilhower merged commit b0a06ed into earlephilhower:master Dec 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Misterke @earlephilhower