Skip to content

Made get_client and get_path_str public (#1487) #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paraseba merged 1 commit into from
Dec 16, 2025
Merged

Made get_client and get_path_str public (#1487) #1489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions icechunk/src/storage/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ impl S3Storage {
/// client is not serializeable and must be initialized after deserialization. Under normal construction
/// the original client is returned immediately.
#[instrument(skip_all)]
async fn get_client(&self, settings: &Settings) -> &Arc<Client> {
pub async fn get_client(&self, settings: &Settings) -> &Arc<Client> {
self.client
.get_or_init(|| async {
Arc::new(
Expand All @@ -260,7 +260,7 @@ impl S3Storage {
.await
}

fn get_path_str(&self, file_prefix: &str, id: &str) -> StorageResult<String> {
pub fn get_path_str(&self, file_prefix: &str, id: &str) -> StorageResult<String> {
let path = PathBuf::from_iter([self.prefix.as_str(), file_prefix, id]);
let path_str =
path.into_os_string().into_string().map_err(StorageErrorKind::BadPrefix)?;
Expand Down
Loading