Skip to content

Conversation

@jayendra13
Copy link

Improves Python repr for core classes

@paraseba
Copy link
Collaborator

Wow this is looking great @jayendra13 !!

@paraseba
Copy link
Collaborator

Don't worry about the Rust failures, that's because you don't have permissions to run tests that require secrets. But you do need to run ruff to fix the code quality test.

Also, it would be great to have some minimal testing

@jayendra13
Copy link
Author

Yes, tests are the next things, I am going to work on, created a draft PR to know weather the efforts are in correct directions or not and I am covering the necessary classes or not. Would love to hear any feedbacks.
Let me run the ruff as well.

@jayendra13
Copy link
Author

Amended the commit to handle the rust linting failures.

@paraseba
Copy link
Collaborator

This looks great @jayendra13 !! Feel free to flag as ready for review. We'll have to wait a few days until @TomNicholas has some time to review, he has more context on this topic than I do. But we'll probably merge soon.

Thank you!

@paraseba paraseba requested a review from TomNicholas December 19, 2025 20:47
@jayendra13 jayendra13 marked this pull request as ready for review December 19, 2025 20:49
@jayendra13
Copy link
Author

Will work on test cases here soon, if we want them in the same PR.

@paraseba
Copy link
Collaborator

Same PR is preferred @jayendra13 . We don't need to be very thorough for this, just a basic test or two. Thanks again!

@jayendra13 jayendra13 force-pushed the main branch 2 times, most recently from f6ec2ac to 4ac53cc Compare December 20, 2025 16:47
@jayendra13
Copy link
Author

Added simple regex and string matching based python test cases for three classes

  • Repository
  • Store
  • Session

with only InMemory storage use-case.

@paraseba
Copy link
Collaborator

rebasing will get rid of the dependency check error

@jayendra13
Copy link
Author

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nicer python reprs (string and HTML)

2 participants