Add configurable max_arrays_to_scan to ManifestPreloadConfig (#1464) #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over#1464) Allow users to configure the maximum number of arrays scanned during manifest preloading. Previously hardcoded to 50, this limit could cause preloading to stop early for repositories with many nested groups. Default remains 50 for backward compatibility.
Collaborator
|
This looks great @aladinor! |
Collaborator
|
@aladinor don't worry about the Rust test failures, it's just that you don't have permissions to get secrets to run those tests. The only thing we need to do is to run Thank you! |
Collaborator
|
Ah, and I think you'll also need to modify the |
paraseba
reviewed
Dec 18, 2025
Collaborator
|
I'll merge this. Thank you @aladinor ! If you need this released before Icechunk 2.0 comes out, can you create a similar PR in the |
Contributor
Author
|
Thanks @paraseba! I'm fine waiting for 2.0 - no rush on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to configure the maximum number of arrays scanned during manifest preloading. Previously hardcoded to 50, this limit could cause preloading to stop early for repositories with many nested groups.
Default remains 50 for backward compatibility.