Skip to content

Make spec_version a property instead of a function #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpiannucci merged 1 commit into from
Dec 19, 2025
Merged

Make spec_version a property instead of a function #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions icechunk-python/python/icechunk/_icechunk_python.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,6 +1814,7 @@ class PyRepository:
async def inspect_snapshot_async(
self, snapshot_id: str, *, pretty: bool = True
) -> str: ...
@property
def spec_version(self) -> int: ...

class PySession:
Expand Down
3 changes: 2 additions & 1 deletion icechunk-python/python/icechunk/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,5 +1656,6 @@ async def inspect_snapshot_async(
) -> str:
return await self._repository.inspect_snapshot_async(snapshot_id, pretty=pretty)

@property
def spec_version(self) -> int:
return self._repository.spec_version()
return self._repository.spec_version
1 change: 1 addition & 0 deletions icechunk-python/src/repository.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2306,6 +2306,7 @@ impl PyRepository {
})
}

#[getter]
fn spec_version(&self) -> u8 {
pyo3_async_runtimes::tokio::get_runtime().block_on(async move {
let repo = self.0.read().await;
Expand Down
10 changes: 5 additions & 5 deletions icechunk-python/tests/test_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,26 @@ def test_migration_1_to_2_dry_run(tmpdir: Path) -> None:
shutil.copytree("tests/data/test-repo-v1", tmpdir, dirs_exist_ok=True)
storage = ic.local_filesystem_storage(str(tmpdir))
repo = ic.Repository.open(storage)
assert repo.spec_version() == 1
assert repo.spec_version == 1

# running by default with dry_run=True
ic.upgrade_icechunk_repository(repo)

repo = ic.Repository.open(storage)
assert repo.spec_version() == 1
assert repo.spec_version == 1

# running with explicit dry_run=True
ic.upgrade_icechunk_repository(repo, dry_run=True)
repo = ic.Repository.open(storage)
assert repo.spec_version() == 1
assert repo.spec_version == 1


def test_migration_1_to_2(tmpdir: Path) -> None:
shutil.copytree("tests/data/test-repo-v1", tmpdir, dirs_exist_ok=True)
storage = ic.local_filesystem_storage(str(tmpdir))
repo = ic.Repository.open(storage)
assert repo.spec_version() == 1
assert repo.spec_version == 1

ic.upgrade_icechunk_repository(repo, dry_run=False)
repo = ic.Repository.open(storage)
assert repo.spec_version() == 2
assert repo.spec_version == 2
4 changes: 2 additions & 2 deletions icechunk-python/tests/test_spec_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
def test_create_repo_with_spec_version_2() -> None:
storage = ic.in_memory_storage()
ic.Repository.create(storage, spec_version=2)
assert ic.Repository.open(storage).spec_version() == 2
assert ic.Repository.open(storage).spec_version == 2


def test_create_repo_with_spec_version_1() -> None:
storage = ic.in_memory_storage()
ic.Repository.create(storage, spec_version=1)
assert ic.Repository.open(storage).spec_version() == 1
assert ic.Repository.open(storage).spec_version == 1


def test_cannot_amend_with_spec_version_1() -> None:
Expand Down