Backport: Virtual chunk storage stats #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1483) * define rust struct * expose struct in python * add python docstrings * extend repo_chunks_storage calculation to include virtual and native chunks (double-counting virtual chunks that don't have checksums) * fully deduplicate virtual chunks when counting by using (url, offset, length) tuple if checksum not available * factor out helper function * compile icechunk-python * rewire existing python method to use new method * add async method * update outdated comment * add python deprecation warnings * restrict to pub(crate) * correct bug in calculation of non-virtual bytes * only use (location, offset, length) as an identifier fo de-duplicating virtual chunks * add todo comment about cloning * use the inner pattern to wrap the rust-only struct inside the python-exposed one * correct name of python class * expose __add__ method in python * cargo formatting for python crate too * rust tests * correct python return type * actually correct python return type * call async method in python * update .pyi file with new methods * python linting * explicitly specify stacklevel for warning * expect warnings in tests
TomNicholas
changed the title
paraseba
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1483 but for v1 branch, so needed to fully close #1478