expire_ref can now edit snapshot pointed by refs
#870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small deviation from the design document. But there is no objective reason why not to do this. By looking at the tests cases you'll see this expiration algorithm is more aggressive, it frees more snapshots, but we believe it's sound. This is
dcherian
reviewed
Mar 27, 2025
dcherian
approved these changes
Mar 28, 2025
dcherian
added a commit
that referenced
this pull request
Mar 31, 2025
* main: (29 commits) Release version 0.2.11 (#879) Release version v0.2.10 (#877) One more GC bugfix (#878) Remove cache entries during GC (#875) Add lookup_snapshot (#876) Add logging to GC and expiration (#874) Fix ref delete during ref expiration (#873) Bump the rust-dependencies group across 1 directory with 3 updates (#872) `expire_ref` can now edit snapshot pointed by refs (#870) Fix repo serialization with default commit metadata (#863) Fix bug in expiration that creates a commit loop (#869) Uncomment `delete_branch` in stateful repo ops test (#866) Add upstream dev CI (#862) Add optional default commit metadata to `Repository` (#860) Update GC docstrings (#858) Add expiration/GC notebook (#857) Small docs polish (#856) Release version 0.2.9 (#855) Add support for virtual chunks in GCS (#853) Cargo deny is smarter in new Rust version (#854) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small deviation from the design document. But there is no objective reason why not to do this. By looking at the tests cases you'll see this expiration algorithm is more aggressive, it frees more snapshots, but we believe it's sound.
This is