Skip to content

Commit

Permalink
CI/Tests: Debug/fix installation on Python 3.6 to 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
amotl committed Apr 9, 2023
1 parent b44efa7 commit 2ec17f6
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ "ubuntu-20.04" ]
python-version: [ "3.6", "3.7", "3.8", "3.9", "3.10", "3.11" ]
os: [ "ubuntu-latest" ]
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11" ]

name: Python ${{ matrix.python-version }} on OS ${{ matrix.os }}
steps:
Expand Down
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ development
- Tests: Add software tests
- Improve documentation
- CI: Add GHA configuration to invoke software tests
- CI/Tests: Fix installation on Python 3.7 to 3.9

2020-12-29 0.11.0
=================
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@ pypi-upload: install-releasetools

install-package:
@test -e $(python) || python3 -m venv $(venv)
@$(pip) install --quiet --use-pep517 --prefer-binary --editable=.[test,develop,release,sql]
$(pip) install --prefer-binary --editable=.[test,develop,release,sql]

install-doctools:
@test -e $(python) || python3 -m venv $(venv)
@$(pip) install --quiet --requirement requirements-docs.txt --upgrade
$(pip) install --requirement requirements-docs.txt --upgrade

install-releasetools:
@test -e $(python) || python3 -m venv $(venv)
@$(pip) install --quiet --requirement requirements-release.txt --upgrade
$(pip) install --requirement requirements-release.txt --upgrade

install-tests:
@test -e $(python) || python3 -m venv $(venv)
@$(pip) install --quiet --requirement requirements-tests.txt --upgrade
$(pip) install --requirement requirements-tests.txt --upgrade
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
classifiers=[
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Expand Down Expand Up @@ -81,7 +80,7 @@
install_requires=requires,
tests_require=test_requires,
extras_require={
'sql': ['duckdb<0.7']
'sql': ['duckdb>=0.3,<0.7']
},
dependency_links=[
],
Expand Down
Empty file added tests/__init__.py
Empty file.
3 changes: 3 additions & 0 deletions tests/test_metadata.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import json
import sys

import pytest
from datadiff.tools import assert_equal

from tests.util import run_command
Expand Down Expand Up @@ -66,6 +68,7 @@ def test_cli_list_quality_levels(capsys):
assert_equal(response, reference)


@pytest.mark.skipif(sys.platform == "linux", reason="Charset encoding weirdness!")
def test_cli_list_quality_bytes(capsys):
"""
CLI test: Verify the `list-quality-bytes` subcommand works.
Expand Down

0 comments on commit 2ec17f6

Please sign in to comment.