Upgrade to Ruby 3.2.8 and update dependencies#27
Merged
Conversation
Bump Ruby version to 3.2.8 and update Gemfile and Gemfile.lock dependencies for compatibility. Remove jeweler and related Rakefile tasks. Refactor code to remove ActiveSupport dependency and update method implementations for Ruby 3.2+. Update VCR cassettes and specs to match new Ruby and gem versions.
Deleted the 'minitest-reporters' gem from the Gemfile and Gemfile.lock, cleaning up unused or unnecessary test dependencies.
Added specs to verify method_missing behavior for dynamic property access and to test country_parameters method for correct parameter encoding and handling of optional values.
Eliminated the ':record => :new_episodes' option from VCR.insert_cassette calls in spec files to ensure tests use only existing cassettes. Updated VCR cassette fixtures to remove legacy and duplicate HTTP interactions, keeping only the latest recorded requests.
Bumps the Ruby version from 2.6.10 to 3.2.8 in the GitHub Actions test workflow to ensure compatibility with newer Ruby features and dependencies.
Added tests for multi-language holidays, single-language holidays, fallback behavior when second language is nil or empty, and parsing dates with string values. Also included a test for creating VacationDay from a real API response using VCR.
martingregoire
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Ruby version to 3.2.8 and update Gemfile and Gemfile.lock dependencies for compatibility. Remove jeweler and related Rakefile tasks. Refactor code to remove ActiveSupport dependency and update method implementations for Ruby 3.2+. Update VCR cassettes and specs to match new Ruby and gem versions.