[pull] main from ManimCommunity:main #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier_points()` in `manim.utils.bezier` (#3766) * Optimized manim.utils.partial_bezier_points() * Added split_bezier, subdivide_bezier and bezier_remap, and tests * Use bezier_remap() in VMobject and OpenGLVMobject() * Note that partial_bezier_points is similar to calling split_bezier twice
updated-dependencies: - dependency-name: requests dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) * Optimized AnimationGroup computation of start-end times with lag ratio * Added extra comment for init_run_time * Added full path to imports in composition.py * Optimized AnimationGroup.interpolate * Fixed final bugs * Removed accidental print * Final fix to AnimationGroup.interpolate * Fixed animations being skipped unintentionally * Fix and improve Mobject assertions when adding submobjects * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update examples in Mobject.add() and OpenGLMobject.add() docstrings * overriden -> overridden * Joined string in OpenGLMobject error message * Address requested changes * OpenGLVMObjects -> OpenGLVMobjects * Use tuplify in VGroup.__setitem__() --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add pyproject for ruff * add black config back * Make only formatting * rearrange isort to undo diff * poetry lock * Feedback * style Co-authored-by: Victorien <[email protected]> --------- Co-authored-by: Victorien <[email protected]>
* pre-commit change to ruff * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixes * astral-sh ruff bump --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…erent `pause_ratio` values (#3778) Co-authored-by: Francisco Manríquez Novoa <[email protected]>
…c2p`) and `point_to_coords` (`p2c`) (#3754) * Add shorthand for axes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add spacing Co-authored-by: Victorien <[email protected]> * Convert CoordinateSystem example, and add to NumberLine * Add doctest for NumberLine * Add test * Fix typehint for c2p Co-authored-by: Victorien <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Victorien <[email protected]> Co-authored-by: Francisco Manríquez Novoa <[email protected]>
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.4 → v0.4.5](astral-sh/ruff-pre-commit@v0.4.4...v0.4.5) - [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0) * Fix typo --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JasonGrace2282 <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.5 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.5...v0.4.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Adds Ruff Linting to CI, and replaces isort in the pre-commit config with Ruff's isort rules. Co-authored-by: Victorien <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Victorien <[email protected]>
* Add config for pyupgrade * Fix pyupgrade errors * Unsafe-fixes * Nicer way of formatting Co-authored-by: Victorien <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert "Nicer way of formatting" This reverts commit 48013f4. --------- Co-authored-by: Victorien <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4 to 6.4.1. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.4.0...v6.4.1) --- updated-dependencies: - dependency-name: tornado dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The "insert_n_curves_to_point_list" function requires the "points" argument to be a numpy array, since it calls the "get_bezier_tuples_from_points" function, which requires "points" to be a numpy array because it has the "return points.reshape((-1, nppc, 3))" statement. Ordinary lists do not have a "reshape" method. So we need to convert "sp1" and "sp2" to numpy arrays before calling the "insert_n_curves_to_point_list" function. Co-authored-by: Francisco Manríquez Novoa <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.7 → v0.4.8](astral-sh/ruff-pre-commit@v0.4.7...v0.4.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add typings to OpenGLMobject * Import typing_extensions * Add explicit returns to inner functions in .arrange_in_grid() * Add quotes to parameters in ValueError * Add some more typings * Address requested changes * Type apply_over_attr_arrays with TypeVar * Fix use of TypeVar * Add Vector3D typing in set_x, set_y and set_z
#3797) * fix: importing manim should not trigger pygments.styles.get_all_styles Removed the Code.styles_list attribute. Rewrote the documentation to say that a list of all styles can be generated by calling list(pygments.styles.get_all_styles()). The example in the docstring of Code was rewritten to use an explicit code style name. * fix: small change to documentation * Added potential class method to get available code styles. * Adding typehints to newly-added attributes. Co-authored-by: adeshpande <[email protected]> * Removing unnecessary lines. Co-authored-by: adeshpande <[email protected]> --------- Co-authored-by: adeshpande <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
* docs: add manim.typing guide * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add colors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add another example for when to typehint as Vector * Add docs for images+functions * write Beziers * Improve based on feedback * type -> Type --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Manríquez Novoa <[email protected]>
…3786) * Make `Line::set_points_by_ends` behavior consistent with constructor * Use `Line::set_points_by_ends` in edge updaters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Undo unnecessary change to Graph * Update manim/mobject/geometry/line.py Co-authored-by: Francisco Manríquez Novoa <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Manríquez Novoa <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat(autoaliasattr): Implement Documentation of TypeVar's * Feedback --------- Co-authored-by: Francisco Manríquez Novoa <[email protected]>
…rrow (#3706) * my test is not passing, i need to add a little bit of docs. except that everything is fine. Issue is solved! * fixed the issue #3655 * removed comments * fix: 3706 original issue, without adding unnecessary dot added: i added self.height parameter in Cone class my tests passes * Changes that way how end point of Arrow3D is calculated. * I've improved the methods get_start and get_end for the Cone class, and get_end for the Arrow3D class to ensure they return accurate geometrical points after transformations. Additionally, I've included unit tests to verify the correctness of these methods for the Cone class. * Finished! Replaced VMobject by VectorizedPoint as Ben suggested while ago * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Manríquez Novoa <[email protected]>
#3767) * Optimized manim.utils.get_smooth_cubic_bezier_handle_points() * Fixed typo in docstring regarding vector u * Add tests for get_smooth_cubic_bezier_handle_points * Fix backreference in test docstrings Co-authored-by: adeshpande <[email protected]> --------- Co-authored-by: adeshpande <[email protected]>
…buffer in x and y direction independently (#4390) * Give SurroundingRectangle 2D buffer * add test for SurroundingRectangle buff parameter --------- Co-authored-by: Benjamin Hackl <[email protected]>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
Co-authored-by: Benjamin Hackl <[email protected]>
…e `FloatRGBA_Array` (#4386) Co-authored-by: Benjamin Hackl <[email protected]>
…deMobject (#4392) Co-authored-by: Francisco Manríquez Novoa <[email protected]>
…4394) Co-authored-by: Francisco Manríquez Novoa <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.8 → v0.12.9](astral-sh/ruff-pre-commit@v0.12.8...v0.12.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* edit: added the descriptions to /docs/source/index.rst * apply suggestions from review --------- Co-authored-by: Benjamin Hackl <[email protected]>
* feat(manim.mobject.opengl): added type annotations for `opengl_compatibility.py` * feat(manim.mobject.opengl): typed almost all attribute definitions in `OpenGLMobject.__init__` * feat(manim.mobject.opengl): typed more methods for `OpenGLMobject` * fix(manim.mobject.opengl): import `override` from `typing_extensions` * fix(manim.mobject.opengl): import `Never` from `typing_extensions` * feat(manim.utils.config_ops): made `_Data` descriptor generic, to allow correctly typing `OpenGLMobject` * fix(mypy.ini): don't ignore `manim.mobject.opengl.opengl_mobject` * fix(manim.utils.config_ops): import `TypeVar` from `typing_extensions`, because the `typing` one does not have the `default` argument. * feat(manim.mobject.opengl.opengl_mobject): Type checked more methods in `OpenGLMobject`. * fix(manim.mobject.opengl.opengl_mobject): Fix a typo in `OpenGLMobject.restore`. * feat(manim.mobject.opengl.opengl_mobject): Typed more methods in `OpenGLMobject`. * feat(manim.mobject.opengl.opengl_mobject): Moved `overload`s inside an `if TYPE_CHECKING` statement. * feat(manim.mobject.opengl.opengl_mobject): Added type annotations for `**kwargs` in a set of related methods. * Revert "feat(manim.mobject.opengl): added type annotations for `opengl_compatibility.py`" This reverts commit 1cd1550. * fix(OpenGLMobject): defined `get_array_attrs` method (and typed `_original__init__` at class scope). I followed the advice of an existing `# TODO` comment and the implementation in `Mobject`. This also resolves a mypy error in this class (missing attribute). It's interesting because the `get_array_attrs` method is (was) only defined in three classes: - `Mobject` - `PMobject` - `OpenGLPMobject` * feat(manim.mobject.opengl.opengl_mobject): Added type annotations for the `override_animate()`. * feat(manim.mobject.opengl.opengl_mobject): Added type annotations to `_AnimationBuilder` and some methods in `OpenGLPoint`. * fix(manim.mobject.opengl.opengl_mobject): fix failing tests * fix(OpenGLMobject): default implementation of `pointwise_become_partial(…)` had to return `self`! * feat(OpenGLMobject): added `type: ignore[no-untyped-call]` for calls to `ShaderWrapper` methods (not yet annotated). * feat(OpenGLMobject): annotated shader-related `ClassVar`s * feat(OpenGLMobject): typed several `**kwargs` and added `type: ignore[no-any-return]`s for cases where mypy cannot understand operations on numpy arrays. * feat(OpenGLMobject): typed more `**kwargs` and fixed `set_color` arguments * feat(OpenGLMobject): Added more type annotations. * feat(OpenGLMobject): Typed `OpenGLMobject.uniforms` and `OpenGLMobject.fixed_orientation_center` * fix(OpenGLMobject): fix tests * fix(OpenGLGroup): annotate `**kwargs` * fix(OpenGLPoint): annotate `**kwargs` * fix(OpenGLPoint): corrected `**kwargs` and removed two `type: ignore`s * fix(OpenGLPoint): removed `# type: ignore[no-untyped-call]`s * fix(ci): import `Self` from `typing_extensions` rather than `typing`. * fix(ci): import `TypeAlias` from `typing_extensions` rather than `typing`. * feat(OpenGLMobject): make use of PEP 728. * fix(ci): update `typing-extensions` requirement to the first version that supports PEP 728. * fix(OpenGLMobject): avoid variable redefinitions in the `arrange_in_grid` method. * fix(mypy.ini): remove unused changes to `mypy` configuration. * fix(OpenGLMobject): use different symbols for the two `updater` variables. * Revert "fix(ci): update `typing-extensions` requirement to the first version that supports PEP 728." This reverts commit 69b96c6. * fix(OpenGLMobject): remove `TypedDict`s and switch to the less precise `**kwargs: Any`. * Handle three no-any-return issues. * Removed the slash divider in function parameters * Removed the slash divider in function parameters * Keep a single slash divider - to make return types match --------- Co-authored-by: Henrik Skov Midtiby <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Henrik Skov Midtiby <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.9 → v0.14.1](astral-sh/ruff-pre-commit@v0.12.9...v0.14.1) - [github.com/pre-commit/mirrors-mypy: v1.17.1 → v1.18.2](pre-commit/mirrors-mypy@v1.17.1...v1.18.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Henrik Skov Midtiby <[email protected]>
…ht, width→pixel_width (#4440) Co-authored-by: Henrik Skov Midtiby <[email protected]>
…#4080) * fixed problem with type conversions in Line3D * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed broken test and Arrow3D * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update manim/mobject/three_d/three_dimensions.py Co-authored-by: Aarush Deshpande <[email protected]> * Update manim/mobject/three_d/three_dimensions.py Co-authored-by: Aarush Deshpande <[email protected]> * Delete unnecessary file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed typo in variable nam --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Benjamin Hackl <[email protected]>
…ettings (#4452) * swapped height and width values * updated default resolution settings
Co-authored-by: Francisco Manríquez Novoa <[email protected]> Co-authored-by: Henrik Skov Midtiby <[email protected]>
* fixed problem: default value of color in styles in CodeMobject * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added accidently removed test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update code_mobject.py Code suggested by maejam --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Henrik Skov Midtiby <[email protected]> Co-authored-by: Henrik Skov Midtiby <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.1 → v0.14.2](astral-sh/ruff-pre-commit@v0.14.1...v0.14.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add implementation for tangential arc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add example * Improve doc slightly * Remove corner type * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add test for TangentialArc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Import Line only if type checking * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add missing type hint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add test for tangential arc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* added option to render all scenes by typing '*' when prompted * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…Fixes #4445 (#4478) * Add regression tests for about_point view mutation issue This adds regression tests for issue #4445 where using get_vertices()[0] as about_point in transformation methods would cause incorrect results due to numpy array view mutation. Tests added: - test_rotate_about_vertex_view - test_scale_about_vertex_view - test_stretch_about_vertex_view - test_apply_matrix_about_vertex_view - test_opengl_rotate_about_vertex_view (OpenGL was not affected by the bug) Related to #4445 * Fix about_point view mutation in apply_points_function_about_point When about_point parameter receives a numpy array view (e.g., from get_vertices()[0]), the in-place operation `mob.points -= about_point` would mutate the view, corrupting the transformation calculation. This fix copies about_point before using it to prevent view mutation. The OpenGL renderer was not affected by this bug because it uses `arr - about_point` (creates temporary) instead of `arr -= about_point` (mutates in-place). Fixes #4445 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…4480) * Set the default python version to 3.13 in the uv installation guide. * Capitalize Python --------- Co-authored-by: Francisco Manríquez Novoa <[email protected]>
…n are still updated (#4402) Co-authored-by: Francisco Manríquez Novoa <[email protected]>
* Give LabeledDot a buffer and improve radius calculation * fix norm calculation * documentation --------- Co-authored-by: Francisco Manríquez Novoa <[email protected]>
… in mapbox_earcut==2.0.0 (#4479) Co-authored-by: Francisco Manríquez Novoa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
71 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )