add support for container-pdus without sub-pdu Header #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! DRAFT !!
this is part of an bigger change which i tried to split into several pull-requests.
But as the changes depends on each other the splited pull-requests will generate merge-conflicts.
So see this seperated pull-requests as some kind of documentation.
The "big" pull-request which contains everything in a single pull-request which do NOT generate merge-conflicts is: #873
WARNING: most likley #864 is merged before this PR.
You will get an merge-conflict at the call of get_signals() in get_frame_from_container_ipdu().
The version of this PR need to be choosen:
get_signals(pdu_sig_mapping, target_pdu, ea, None, float_factory, bit_offset=0, generated_update_bits_init_to_1=generated_update_bits_init_to_1)
there are two kinds of container-pdus.
there was some kind of support for static container-pdus, but in that case each signal of a static sub-pdu got modified start_bit (increased by the pdu-offset).
That result in a situation where the start_bit was incorrect in relation to the sub-pdu itself.
As the sub-pdu offset was not stored, the user of canmatrix has no possiblity to get the correct signal-startbit positions.
Solution: