fix: use window.location.replace for OAuth redirect to fix back button#10034
Open
BacLuc wants to merge 1 commit into
Open
fix: use window.location.replace for OAuth redirect to fix back button#10034BacLuc wants to merge 1 commit into
BacLuc wants to merge 1 commit into
Conversation
ecamp#5086) window.location.href = url adds the OAuth provider URL to browser history, so after OAuth login the back button navigates to the provider. Replace with window.location.replace(url) which replaces the current history entry instead of pushing a new one. After the OAuth callback the back button now navigates within eCamp rather than to the provider. Fixes ecamp#5086 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.location.href = url adds the OAuth provider URL to browser history, so after OAuth login the back button navigates to the provider.
Replace with window.location.replace(url) which replaces the current history entry instead of pushing a new one. After the OAuth callback the back button now navigates within eCamp rather than to the provider.
Fixes #5086