Nt/vote fixes #3056
Open
Nt/vote fixes #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
setting appropriate observer and current username for profile screen posts/blogs/comments
prefer using voters count from stats instead of active_votes
conditionally fetch and use vote status from
database_api.list_votesif active voters exceed 1K and user vote is not found in post data.Initially my plan was to only fetch vote status in blog details page but adding new condition of 1K+ voters and user vote absent from the post data really reduces the impact it can have on feed list fetch, considering we do not get many posts with 1K+ votes when scrolling feeds generally.
Where should the reviewer start?
Steps to reproduce
Issue number
fixes https://github.com/orgs/ecency/projects/4/views/1?filterQuery=vote&pane=issue&itemId=132763387
fixes https://discord.com/channels/@me/920267778190086205/1429953864228147301
Screenshots/Video