-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add English translation #14
base: master
Are you sure you want to change the base?
Conversation
Fix links
Update links in README to repository
First of all, welcome onboard! You are making positive contributions now. Since you are onboard, I need to share some of the maintenance burden with you. echarts-countroes-js is the target folder, containing all minified, uglified javascripts, which is not human readable. Hence, I prefer that we keep a source directory to keep human readable javascripts, like switzerland country js. Yes, it is arguable where to put yours as the majority of them are from starbucks repo. Suggestion are welcome. But as of the current state of this PR, I am afraid that it is not maintainable for me. |
here is the example source directory: https://github.com/echarts-maps/echarts-countries-js/tree/master/geojson/shape-with-internal-borders |
here is the pyecharts registry file: https://github.com/echarts-maps/echarts-countries-js/blob/master/registry.json Yes, pyecharts from Python can use this package too! |
please note also, this repo has gulpfile for automation: https://github.com/echarts-maps/echarts-countries-js/blob/master/gulpfile.js. although it is old version 3 style. |
Thanks for the review. It would be helpful to support more than just Mandarin and English. It seems there is some software for Javascript localization:
Comments on the above options and suggestions for other options or a custom solution are helpful. So far eCharts seems to have Mandarin and English support, though not yet a localization and internationalization strategy that would allow more languages without increasing developer time. |
https://github.com/apache/incubator-echarts/tree/master/src they support these additional languages: ES, FI, TH |
One more thing, I could not follow what's changed in this PR. what natural earth did to their json assets, they provided name_zh, name_en in properties. but echarts only pick 'name' as its display name. |
Have added English translation to preview.html as preview-en.html by changing the javascript map files. Is it better to create additional javascript loading options per language (for example using po files), or to have multiple map directories, one for each language?