Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Replace toggleSidebar() with new SidebarUI methods #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Replace toggleSidebar() with new SidebarUI methods #38

wants to merge 1 commit into from

Conversation

YoruNoHikage
Copy link
Member

While fixing blank tweets problem, I encountered warnings about this methods being deprecated.
Is there anybody still using old versions of Firefox ?

@YoruNoHikage
Copy link
Member Author

Well... I just encountered new errors, do not merge now please. :'(

@ath0mas
Copy link
Member

ath0mas commented Dec 19, 2015

Just to paste browser console deprecation warning you mentioned:

DEPRECATION WARNING: toggleSidebar() is deprecated, please use SidebarUI.toggle() or SidebarUI.show() instead
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Sidebar
...

@ath0mas
Copy link
Member

ath0mas commented Dec 19, 2015

Where to find documentation on SidebarUI?

@YoruNoHikage
Copy link
Member Author

I think this is this object https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_sidebar#Sidebar%28options%29

@YoruNoHikage YoruNoHikage mentioned this pull request Dec 20, 2015
Open
@ath0mas ath0mas changed the title Replace toggleSidebar() with new SidebarUI methods [WIP] Replace toggleSidebar() with new SidebarUI methods Jan 27, 2016
@YoruNoHikage YoruNoHikage added this to the 2.6.x milestone Jan 28, 2016
@YoruNoHikage
Copy link
Member Author

Could be useful : https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sidebar.js#328-337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YoruNoHikage @ath0mas