Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose encoding facility, closes #37 #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

safanaj
Copy link

@safanaj safanaj commented Nov 15, 2022

  • expose bech32 module for easy marshalling
  • added support for stake addresses
  • added convinient method to build stake credential from key hash

@safanaj
Copy link
Author

safanaj commented Nov 15, 2022

ping @echovl

* expose bech32 module for easy marshalling
* added convinient method to build stake credential from key hash

Signed-off-by: Marco Bardelli <[email protected]>
@safanaj
Copy link
Author

safanaj commented Dec 5, 2022

@echovl @kevink1103 I updated this PR removing the addition of StakeAddress type as we agreed to prefer #46 .
In this PR still the improvement / exposure of convenient bech32 encoding functions and an additional convenient way to create StakeCredential from the pubkey hash directly.

@safanaj safanaj changed the title Improve addresses and encoding, closes #37 Expose encoding facility, closes #37 Dec 5, 2022
@echovl
Copy link
Owner

echovl commented Dec 20, 2022

@safanaj looks ok to me but it needs some unit tests, that also will help to document the usage.

@safanaj
Copy link
Author

safanaj commented Dec 28, 2022

Hi @echovl , do you mean unit tests to demonstrate how to implement Bech32Codec and Bech32Encoder interfaces?

@safanaj
Copy link
Author

safanaj commented Dec 28, 2022

@echovl I added some unit tests, let me know if that is ok for you, eventually we can add more of them to have a really exhaustive test suite.

Signed-off-by: Marco Bardelli <[email protected]>
Signed-off-by: Marco Bardelli <[email protected]>
@safanaj
Copy link
Author

safanaj commented Jan 13, 2023

ping @echovl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants