Repository navigation
Conversation
mristin
changed the title
empwilli
force-pushed
the
empwilli/typescript-unique-id-short-constraint
branch
from
January 23, 2026 12:27
277588f to
3a242e0
Compare
The implementation of the ID-Short uniqueness constraint in typescript fails when the ID-Short is unset. While an unset ID-Short is invalid in many cases, this check should instead only return false when multiple SubmodelElements have the same ID-Short. Hence, we adapt it to ignore unset ID-Shorts.
empwilli
force-pushed
the
empwilli/typescript-unique-id-short-constraint
branch
from
January 28, 2026 14:44
3a242e0 to
5166076
Compare
mristin
added a commit
that referenced
this pull request
Feb 3, 2026
* Extend ``must_find`` to constants (#564) * Add ``is_literal_of`` method to symbol table (#565) * Add literal value set to IR (#566) * Expose mapping from and to primitive types (#567) * Fix typescript unique ID-Short constraint (#569) * Track descendants of constrained primitives (#573) * Make symbol table pickle-able (#574) * Fix cpp 11 compilation issue (#572) * Fix XML serialization of float in Python (#575) This version provides a set of ergonomic methods for aas-core-testdatagen so that we can generate the test data using reflection on symbol table more easily. In addition, it contains a couple of minor fixes to C++ and Python generators.
Merged
mristin
added a commit
that referenced
this pull request
Feb 3, 2026
* Extend ``must_find`` to constants (#564) * Add ``is_literal_of`` method to symbol table (#565) * Add literal value set to IR (#566) * Expose mapping from and to primitive types (#567) * Fix typescript unique ID-Short constraint (#569) * Track descendants of constrained primitives (#573) * Make symbol table pickle-able (#574) * Fix cpp 11 compilation issue (#572) * Fix XML serialization of float in Python (#575) This version provides a set of ergonomic methods for aas-core-testdatagen so that we can generate the test data using reflection on symbol table more easily. In addition, it contains a couple of minor fixes to C++ and Python generators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the ID-Short uniqueness constraint in typescript fails
when the ID-Short is unset. While an unset ID-Short is invalid in many cases,
this check should instead only return false when multiple SubmodelElements
have the same ID-Short. Hence, we adapt it to ignore unset ID-Shorts.)
Fixes #568.