Repository navigation
Unify tests for main - #598
Merged
Merged
Conversation
We group all the tests for the main method into a since test file. This makes it easier to run only parts of the test suite, and also indicates more clearly how to include tests for novel targets and cases.
mristin
force-pushed
the
mristin/Unify-all-main-tests-into-one
branch
from
March 19, 2026 15:50
ebfaf1e to
56d63a6
Compare
mristin
added a commit
that referenced
this pull request
Sep 30, 2026
Each generator verifies the meta-model on its own, so a meta-model
change which breaks, say, Go went unnoticed unless somebody generated
Go. We now run the full generation of every target in the smoke test,
with dummy snippets into a temporary directory, so that aas-core-meta
can check a meta-model against all the targets at once:
cpp_return_code = _smoke_generate_cpp(
context=run.Context(..., output_dir=cpp_output_dir),
stderr=stderr,
)
The smoke test keeps going after a failing target and reports the
errors of all the targets together.
We move the check of colliding C++ ``Property`` literals from
the generation of the iteration header to ``cpp_lib.verify_for_types``
so that it is reported together with the other C++ name collisions.
We also make ``xsd.main.generate`` public, in line with
``jsonschema.main.generate``.
We restore ``dev/tests/smoke/test_main.py``, which was lost in #598,
and run it additionally over the common meta-models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We group all the tests for the main method into a since test file. This makes it easier to run only parts of the test suite, and also indicates more clearly how to include tests for novel targets and cases.