Repository navigation
Transpile str.rstrip - #859
Merged
Merged
Conversation
We transpile ``text.rstrip(chars)`` to all the targets. As with
``lstrip``, the characters (code points) are stripped as in Python,
never the UTF-16 code units:
common::RStrip(text, chars) // C++
Common.StringHelpers.RStrip(text, chars) // C#
strings.TrimRight(text, chars) // Go
StringHelpers.rstrip(text, chars) // Java
OurCommon.rstrip(text, chars) // TypeScript
C++, C# and Java share the check whether a character is among
the stripped ones between ``lstrip`` and ``rstrip``. The meta-model
``string_operations`` checks ``rstrip`` on characters which share
a surrogate with the stripped ones, *e.g.*, ``"a😀".rstrip("😁")``.
Coverage Report for CI Build 39665495322Coverage increased (+0.02%) to 90.174%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We transpile
text.rstrip(chars)to all the targets. As withlstrip, the characters (code points) are stripped as in Python, never the UTF-16 code units:C++, C# and Java share the check whether a character is among the stripped ones between
lstripandrstrip. The meta-modelstring_operationschecksrstripon characters which share a surrogate with the stripped ones, e.g.,"a😀".rstrip("😁").