Repository navigation
Transpile string concatenation - #861
Merged
Merged
Conversation
We transpile the addition of two strings, ``left + right``, to
the native concatenation in all the targets. The type inference refuses
to mix a string with another type, as the targets convert the other
operand to a string differently, or not at all.
C++ can not add two string literals, as they are pointers, so we
convert the left one:
std::wstring extension = std::wstring(L".") + L"txt";
Along the way, we drop the redundant parentheses around a compound
argument of ``OurCommon.lenStr`` in TypeScript.
Coverage Report for CI Build 39674735794Coverage increased (+0.001%) to 90.201%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We transpile the addition of two strings,
left + right, to the native concatenation in all the targets. The type inference refuses to mix a string with another type, as the targets convert the other operand to a string differently, or not at all.C++ can not add two string literals, as they are pointers, so we convert the left one:
Along the way, we drop the redundant parentheses around a compound argument of
OurCommon.lenStrin TypeScript.