Repository navigation
Make Python HasIterparse compatible with mypy 2.4 - #863
Merged
Merged
Conversation
We bump mypy in the Python live tests from 0.982 to 2.4.0, the version
the generated SDKs use. Its type stubs declare ``iterparse`` of
``xml.etree.ElementTree`` as overloads over literal event names, so
the module no longer satisfies our ``HasIterparse`` protocol, and every
default ``has_iterparse = xml.etree.ElementTree`` fails to type-check.
The protocol now requires only the events we actually pass, without
a default, so that a single overload matches it:
def iterparse(
self, source: TextIO, events: Sequence[Literal["start", "end"]]
) -> Iterator[Tuple[str, Element]]:
This fix is necessary for mypy 2.4.0; the old stubs accept it as well.
Coverage Report for CI Build 39972867254Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 90.201%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We bump mypy in the Python live tests from 0.982 to 2.4.0, the version the generated SDKs use. Its type stubs declare
iterparseofxml.etree.ElementTreeas overloads over literal event names, so the module no longer satisfies ourHasIterparseprotocol, and every defaulthas_iterparse = xml.etree.ElementTreefails to type-check.The protocol now requires only the events we actually pass, without a default, so that a single overload matches it:
This fix is necessary for mypy 2.4.0; the old stubs accept it as well.