Enhanced JDBC driver manager with configuration based on new JVM parameters (#1832) #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speckyspooky
added
the
Enhancement
merks
reviewed
Aug 4, 2024
...e.birt.report.data.oda.jdbc/src/org/eclipse/birt/report/data/oda/jdbc/JDBCDriverManager.java
Show resolved
Hide resolved
| private static final String EMPTY_STRING = ""; //$NON-NLS-1$ | ||
|
|
||
| private boolean isDriverPropertyValidationEnabled = true; | ||
|
|
||
| private String excludedDriverForValidation; |
There was a problem hiding this comment.
The property name "...excluded.drivers" suggests multiple exclusions are support. This field suggest a single one is specified. Later it just does a contains test on the String, so the separator doesn't matter. If you were to write some documentation somewhere how to use system property to exclude multiple drivers from validation, how would you describe the syntax for it?
There was a problem hiding this comment.
Yes, I will create a documentation of it with a README.MD.
Yes, the delimitor is independend because the class name will be checked with "contain()" but I recommand ","-comma.
speckyspooky
force-pushed
the
enhance_jdbc_manager_validation_configurable
branch
from
7777e4e
to
2b0806a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.