Skip to content

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 31, 2025

What does this PR do?

Reworked the Devfile Viewer widget to use the react-codemirror library, which includes all proper styles and uses the actual version of the code editor component.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Try to create a new workspace from the source.
https://gist.githubusercontent.com/olexii4/dfb21012e08eedf8fc17ae608708fe87/raw/bec54efa905b915695dcb7fc5806cb4b456aa343/devfile.yaml
  1. Open Workspace Detail / Devfile page and Devfile Viewer styles should be correct:

Знімок екрана 2025-06-05 о 19 17 08

Release Notes

Docs PR

@olexii4 olexii4 requested review from vinokurig and removed request for ibuziuk and akurinnoy January 31, 2025 16:16
@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2025

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested review from akurinnoy and ibuziuk January 31, 2025 16:17
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1307

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1307", name: che-dashboard}]}}]"

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

❌ Patch coverage is 67.34694% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.00%. Comparing base (3b5b0d4) to head (c8babe0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rd-frontend/src/components/DevfileViewer/index.tsx 75.00% 11 Missing ⚠️
...oard-frontend/src/components/BasicViewer/index.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   91.77%   92.00%   +0.22%     
==========================================
  Files         509      509              
  Lines       47159    47151       -8     
  Branches     3338     3364      +26     
==========================================
+ Hits        43281    43381     +100     
+ Misses       3845     3734     -111     
- Partials       33       36       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Jun 6, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1307

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1307", name: che-dashboard}]}}]"

@olexii4 olexii4 changed the title chore: migrate to react-codemirror [DO NOT MERGE] chore: migrate to react-codemirror Aug 4, 2025
Copy link

github-actions bot commented Oct 1, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1307-amd64

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1307-amd64", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Oct 1, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1307-ppc64le

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1307-ppc64le", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Oct 1, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1307-s390x

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1307-s390x", name: che-dashboard}]}}]"

@olexii4 olexii4 changed the title [DO NOT MERGE] chore: migrate to react-codemirror chore: migrate to react-codemirror Oct 1, 2025
Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

Image

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2025
Copy link

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 58550cb into main Oct 1, 2025
20 of 21 checks passed
@olexii4 olexii4 deleted the CHE-23324 branch October 1, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants