fix: checkForTemplatesUpdate method #1378

olexii4 · 2025-09-17T14:05:49Z

What does this PR do?

This PR updates the heckForTemplatesUpdate method to allow custom editor updates from the .che/che-editor.yaml file before the next workspace start.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23467

Is it tested? How?

Apply dashboard pull request image: quay.io/eclipse/che-dashboard:pr-1378-amd64
Prepare a git repository with .che/che-editor.yaml file with the following content:

reference: https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/che-incubator/che-code/insiders/devfile.yaml
override:
  containers:
    - name: che-code-injector
      memoryLimit: 2048Mi

Create a new workspace from the target repository. Check the che-editor memory limit, it should be 2048Mi.
Update .che/che-editor.yaml file with the following content:

reference: https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/che-incubator/che-code/insiders/devfile.yaml
override:
  containers:
    - name: che-code-injector
      memoryLimit: 4096Mi

Restart the target workspace. Check the che-editor memory limit, it should be 4096Mi.

Release Notes

Docs PR

che-bot · 2025-09-17T14:05:57Z

Click here to review and test in web IDE:

github-actions · 2025-09-17T15:03:18Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

github-actions · 2025-09-18T13:39:55Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-18T13:44:53Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-18T14:04:22Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-18T14:09:04Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-18T14:15:11Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

github-actions · 2025-09-18T14:21:44Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

github-actions · 2025-09-18T15:05:11Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-18T15:28:37Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-18T15:40:15Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>

github-actions · 2025-09-21T18:31:42Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-21T18:54:48Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-21T19:07:10Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>

github-actions · 2025-09-21T22:07:15Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-21T22:31:08Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-21T22:42:24Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

codecov · 2025-09-21T23:18:11Z

Codecov Report

❌ Patch coverage is 85.87571% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.93%. Comparing base (a72f80d) to head (b05c60d).

Files with missing lines	Patch %	Lines
.../actions/actionCreators/helpers/getCustomEditor.ts	77.77%	12 Missing ⚠️
...orkspace-client/devworkspace/devWorkspaceEditor.ts	87.65%	10 Missing ⚠️
...oard-frontend/src/store/FactoryResolver/actions.ts	81.81%	2 Missing ⚠️
...tions/actionCreators/createWorkspaceFromDevfile.ts	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
- Coverage   91.98%   91.93%   -0.05%     
==========================================
  Files         508      509       +1     
  Lines       46984    47052      +68     
  Branches     3356     3364       +8     
==========================================
+ Hits        43217    43258      +41     
- Misses       3730     3755      +25     
- Partials       37       39       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

svor

LGTM
tried to patch editor as described in the description:

Also tested by replacing editor id from idea editor to che-code editor - works as expected

...rontend/src/store/Workspaces/devWorkspaces/actions/actionCreators/helpers/getCustomEditor.ts

svor · 2025-09-23T08:31:50Z

...rontend/src/store/Workspaces/devWorkspaces/actions/actionCreators/helpers/getCustomEditor.ts

  getState: () => RootState,
 ): Promise<string | undefined> {
-  let editorsDevfile: devfileApi.Devfile | undefined;
+  // let editorsDevfile: devfileApi.Devfile | undefined;


do we need this

Thanks. I have fixed it.

olkornii

Tested with Che.
cluster: 4.17 aws,no-spot (via ClusterBot).
oc: 4.19.4
Works for me.

olkornii · 2025-09-23T14:22:21Z

Tested with Devspaces.
cluster: 4.19 personal
oc: 4.19.4
Works for me.

akurinnoy

LGTM

openshift-ci · 2025-09-23T14:42:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, olkornii, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-09-23T14:44:16Z

New changes are detected. LGTM label has been removed.

Signed-off-by: Oleksii Orel <[email protected]>

github-actions · 2025-09-23T14:53:31Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-23T14:54:57Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-amd64

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-amd64", name: che-dashboard}]}}]"

github-actions · 2025-09-23T15:16:57Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-23T15:18:19Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-ppc64le

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-ppc64le", name: che-dashboard}]}}]"

github-actions · 2025-09-23T15:29:12Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

github-actions · 2025-09-23T15:29:42Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1378-s390x

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1378-s390x", name: che-dashboard}]}}]"

olexii4 requested review from akurinnoy and ibuziuk as code owners September 17, 2025 14:05

olexii4 requested a review from svor September 17, 2025 14:09

olexii4 marked this pull request as draft September 17, 2025 14:09

openshift-ci bot added the do-not-merge/work-in-progress label Sep 17, 2025

olexii4 marked this pull request as ready for review September 18, 2025 13:30

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 18, 2025

fix: checkForTemplatesUpdate method

b5813cb

Signed-off-by: Oleksii Orel <[email protected]>

olexii4 force-pushed the CHE-23467 branch from b2cc707 to b5813cb Compare September 21, 2025 18:22

olexii4 added 2 commits September 22, 2025 00:47

fixup! fix: checkForTemplatesUpdate method

306fd3a

Signed-off-by: Oleksii Orel <[email protected]>

fixup! fixup! fix: checkForTemplatesUpdate method

79b6069

Signed-off-by: Oleksii Orel <[email protected]>

eclipse-che deleted a comment from codecov bot Sep 21, 2025

eclipse-che deleted a comment from github-actions bot Sep 21, 2025

eclipse-che deleted a comment from openshift-ci bot Sep 21, 2025

svor approved these changes Sep 23, 2025

View reviewed changes

openshift-ci bot assigned svor Sep 23, 2025

openshift-ci bot added the lgtm label Sep 23, 2025

svor requested a review from olkornii September 23, 2025 12:11

olkornii approved these changes Sep 23, 2025

View reviewed changes

openshift-ci bot assigned olkornii Sep 23, 2025

akurinnoy approved these changes Sep 23, 2025

View reviewed changes

openshift-ci bot assigned akurinnoy Sep 23, 2025

openshift-ci bot removed the lgtm label Sep 23, 2025

fixup! fixup! fixup! fix: checkForTemplatesUpdate method

b05c60d

Signed-off-by: Oleksii Orel <[email protected]>

olexii4 force-pushed the CHE-23467 branch from 30ee3cd to b05c60d Compare September 23, 2025 14:45

fix: checkForTemplatesUpdate method #1378

Are you sure you want to change the base?

fix: checkForTemplatesUpdate method #1378

Conversation

olexii4 commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

Uh oh!

che-bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

codecov bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

svor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

svor Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

olexii4 Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

olkornii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olkornii commented Sep 23, 2025

Uh oh!

akurinnoy left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 23, 2025

Uh oh!

openshift-ci bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

olexii4 commented Sep 17, 2025 •

edited

Loading

codecov bot commented Sep 21, 2025 •

edited

Loading

olkornii left a comment •

edited

Loading