Skip to content

Conversation

JaivigneshJv
Copy link

procedures: Configure ingress-nginx for internet-facing load balancer on EKS

What does this pull request change?

This pull request updates the procedure for installing the Ingress-Nginx Controller on Amazon EKS. It adds a Helm option to configure the AWS load balancer as internet-facing.

Specifically, it adds the following line to the helm install command:
--set controller.service.annotations."service\.beta\.kubernetes\.io/aws-load-balancer-scheme"="internet-facing"

This ensures that the load balancer created for the ingress controller is accessible from the internet, which is a common requirement for public-facing applications.

What issues does this pull request fix or reference?

This change addresses the need for a publicly accessible ingress controller on EKS.

Specify the version of the product this pull request applies to

This applies to Eclipse Che installations on Amazon EKS.

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@JaivigneshJv JaivigneshJv requested review from deerskindoll and a team as code owners July 23, 2025 05:49
@JaivigneshJv JaivigneshJv requested a review from tolusha July 23, 2025 05:49
Copy link

⚡️ Deploying pull request preview...

Copy link

github-actions bot commented Jul 23, 2025

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small tweak


.Prerequisites

* Ensure your VPC subnets have the appropriate tags for load balancer discovery:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Ensure your VPC subnets have the appropriate tags for load balancer discovery:
* Verify that your VPC subnets have the appropriate tags for load balancer discovery:

@deerskindoll
Copy link
Contributor

@JaivigneshJv please follow the ECA validation procedure, we won't be able to merge your PR otherwise

@ibuziuk
Copy link
Member

ibuziuk commented Sep 23, 2025

@tolusha could you please review?
@JaivigneshJv thank you for the contribution, but we will not be able to merge until Eclipse ECA is submitted on your end - https://www.eclipse.org/legal/eca/

@tolusha
Copy link
Contributor

tolusha commented Sep 24, 2025

From my understanding service.beta.kubernetes.io/aws-load-balancer-scheme was introduced in v2.2 with default value internal. Previously it was service.beta.kubernetes.io/aws-load-balancer-internal with default value `false.
So, basically changes look good.

Hello @JaivigneshJv
Could you confirm pls?

https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/service/annotations/#lb-scheme

** For public subnets (with internet gateway routes): `kubernetes.io/role/elb=1`
** For private subnets (without internet gateway routes): `kubernetes.io/role/internal-elb=1`
** For all subnets: `kubernetes.io/cluster/<CLUSTER_NAME>=shared` or `kubernetes.io/cluster/<CLUSTER_NAME>=owned`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain pls, why those prerequisites are needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants