-
Notifications
You must be signed in to change notification settings - Fork 171
docs: update prerequisites for installing Ingress-Nginx Controller on… #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
⚡️ Deploying pull request preview... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small tweak
|
||
.Prerequisites | ||
|
||
* Ensure your VPC subnets have the appropriate tags for load balancer discovery: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Ensure your VPC subnets have the appropriate tags for load balancer discovery: | |
* Verify that your VPC subnets have the appropriate tags for load balancer discovery: |
@JaivigneshJv please follow the ECA validation procedure, we won't be able to merge your PR otherwise |
@tolusha could you please review? |
From my understanding Hello @JaivigneshJv |
** For public subnets (with internet gateway routes): `kubernetes.io/role/elb=1` | ||
** For private subnets (without internet gateway routes): `kubernetes.io/role/internal-elb=1` | ||
** For all subnets: `kubernetes.io/cluster/<CLUSTER_NAME>=shared` or `kubernetes.io/cluster/<CLUSTER_NAME>=owned` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain pls, why those prerequisites are needed?
procedures: Configure ingress-nginx for internet-facing load balancer on EKS
What does this pull request change?
This pull request updates the procedure for installing the Ingress-Nginx Controller on Amazon EKS. It adds a Helm option to configure the AWS load balancer as internet-facing.
Specifically, it adds the following line to the
helm install
command:--set controller.service.annotations."service\.beta\.kubernetes\.io/aws-load-balancer-scheme"="internet-facing"
This ensures that the load balancer created for the ingress controller is accessible from the internet, which is a common requirement for public-facing applications.
What issues does this pull request fix or reference?
This change addresses the need for a publicly accessible ingress controller on EKS.
Specify the version of the product this pull request applies to
This applies to Eclipse Che installations on Amazon EKS.
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.