Remove generics from Peaks #2046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPeaksis a glorified list of peaks with a name attached to it. It is generic, leading to a difficult to readIProcessingInfo<IPeaks<IPeakMSD>>API which seems a bit odd conceptually, and it is only ever used in a context about MSD peaks, so I renamed and simplified it. There was one occasion in the PCA perspective with non MSD peaks, but I could just replace it with aList<IPeak>as it is kinda pointless there. Maybe we can get rid of it entirely at one point.ChromatogramPeakswas completely unused, so I removed it instead of porting it. Also removed extensions methods fromIChromatogramPeaksthat were only used in one place.