Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wizard interface for the task selection page #450

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

marvinvo
Copy link

@marvinvo marvinvo commented Oct 13, 2021

Signed-off-by: Marvin Philipp Vogel [email protected]

Description

This commit changes the gui for the code generators task selection. It shows all titles and descriptions of the task next to their buttons and not only the button, but also the text is clickable.
It also removes the arbitrarily default selected task, so the user has to actively choose a task before he could continue.

Screenshot of old page:
Old

Screenshot of new page:
New

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • pictures of the page would need an update

How Has This Been Tested?

  • Manually checking all navigation options and resizing window

Test Configuration:

  • Eclipse Version: 4.21.0
  • Java Version: 1.8
  • OS: macOS

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@schlichtig
Copy link
Contributor

  • Can you change the icons with their respective explanation into one clickable button?

  • Can you also add shadows to the buttons?

@schlichtig schlichtig self-requested a review October 13, 2021 15:12
@marvinvo
Copy link
Author

marvinvo commented Oct 14, 2021

  • Can you change the icons with their respective explanation into one clickable button?

Buttons cannot hold a layout. Hence it is not possible to put all text well formatted into it.
A workaround is, to put the current button into the group with the text.

  • Can you also add shadows to the buttons?

So with the workaround, the button is actually a SWT Group. You can add shadow as a style to each group, but on my display it didn't show any effect.

Futhermore I tried to work with different colors for the selected items, but that will lead to issues with different color themes, e.g. the dark mode. An alternative is, to make the button a radio button. A screenshot of how it would look like is here:

New2

@AnakinRaW
Copy link
Contributor

@marvinvo Is the screen sizable? If so, do we have scrollbars or a dynamic button layout so everything can be visible. E.g in the last screenshot it looks like the last item group got cut off.

@marvinvo
Copy link
Author

@marvinvo Is the screen sizable? If so, do we have scrollbars or a dynamic button layout so everything can be visible. E.g in the last screenshot it looks like the last item group got cut off.

The window is resizeable. Also all items are contained in a ScrollableComposite, which can scroll vertically and horizontally through the list.
I could try to make the scrollbar permanently visible when content is overflowing.

@marvinvo marvinvo closed this Mar 14, 2022
@marvinvo marvinvo reopened this Mar 14, 2022
@marvinvo marvinvo closed this Jun 20, 2022
@marvinvo marvinvo reopened this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants