fix aggregation metrics config unnecessary force of tags #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Stanchev <[email protected]>
Signed-off-by: Aleksandar Stanchev <[email protected]>
alstanchev
force-pushed
the
bugfix/aggregation-metrics-tags
branch
from
ff6178e to
4f63fb0
Compare
thjaeckle
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags resolving relies on the fields configured in the group-by field of config but group-by does not rely on tags.
Some times we may want to group by a field that we don't want as a tag so this fix removes the unwanted forcing af adding tags.
Also renamed the variable of AggregateThingsMetricsActor to comply with the overall code pattern and to easily find the actor behind the ActorRef