[measurement] Reuse Serializers for High Level Measurement API #2087
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <ecal/measurement/measurement.h> | ||
|
|
||
| namespace eCAL | ||
| { | ||
| namespace measurement | ||
| { | ||
| class IBinaryChannel | ||
| class IChannel |
There was a problem hiding this comment.
warning: destructor of 'IChannel' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]
class IChannel
^Additional context
contrib/measurement/base/include/ecal/measurement/imeasurement.h:35: make it public and virtual
class IChannel
^| : channel(channel_) | ||
| , meas(meas_) | ||
| IChannel(std::shared_ptr<experimental::measurement::base::Reader> meas_, experimental::measurement::base::Channel channel_) | ||
| : meas(meas_) |
There was a problem hiding this comment.
warning: parameter 'meas_' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
| : meas(meas_) | |
| : meas(std::move(meas_)) |
| , meas(meas_) | ||
| IChannel(std::shared_ptr<experimental::measurement::base::Reader> meas_, experimental::measurement::base::Channel channel_) | ||
| : meas(meas_) | ||
| , channel(channel_) |
There was a problem hiding this comment.
warning: parameter 'channel_' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
| , channel(channel_) | |
| , channel(std::move(channel_)) |
| { | ||
| namespace measurement | ||
| { | ||
| class IBinaryChannel |
There was a problem hiding this comment.
warning: destructor of 'IBinaryChannel' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]
class IBinaryChannel
^Additional context
contrib/measurement/base/src/imeasurement.cpp:35: make it public and virtual
class IBinaryChannel
^| { | ||
| public: | ||
| IBinaryChannel(std::shared_ptr<experimental::measurement::base::Reader> meas_, experimental::measurement::base::Channel channel_) | ||
| : meas(meas_) |
There was a problem hiding this comment.
warning: parameter 'meas_' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
| : meas(meas_) | |
| : meas(std::move(meas_)) |
| { | ||
| public: | ||
| OChannel(std::shared_ptr<experimental::measurement::base::Writer> meas_, std::string name_, const eCAL::experimental::measurement::base::DataTypeInformation& datatype_info) | ||
| : binary_channel(meas_, name_, datatype_info) |
There was a problem hiding this comment.
warning: parameter 'meas_' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
| : binary_channel(meas_, name_, datatype_info) | |
| : binary_channel(std::move(meas_), name_, datatype_info) |
|
|
||
| OChannel<T>& operator<<(const Frame<T>& entry_) | ||
| { | ||
| eCAL::message::Serialize(entry_.message, buffer); |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::Serialize(entry_.message, buffer);
^|
|
||
|
|
||
| // Streaming operator to change the sender ID | ||
| OChannel<T>& operator<<(const SenderID& id_) |
There was a problem hiding this comment.
warning: unknown type name 'SenderID' [clang-diagnostic-error]
OChannel<T>& operator<<(const SenderID& id_)
^| { | ||
| static T msg; | ||
| const eCAL::experimental::measurement::base::DataTypeInformation datatype_info{ | ||
| eCAL::message::GetTypeName(msg), |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::GetTypeName(msg),
^| static T msg; | ||
| const eCAL::experimental::measurement::base::DataTypeInformation datatype_info{ | ||
| eCAL::message::GetTypeName(msg), | ||
| eCAL::message::GetEncoding(msg), |
There was a problem hiding this comment.
warning: no member named 'message' in namespace 'eCAL' [clang-diagnostic-error]
eCAL::message::GetEncoding(msg),
^
KerstinKeller
force-pushed
the
feature/msg-measurement
branch
from
400f940 to
398176b
Compare
Before, Serialization / Deserialization for pubsub and measurement were separated and included code duplication.
The measurement implementation now reuses the pubsub serialization implementation to provide a highl level interface to read measurements for all supported serialization formats.