Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sample] aligned sample names #2088

Merged
merged 3 commits into from
Mar 27, 2025
Merged

[sample] aligned sample names #2088

merged 3 commits into from
Mar 27, 2025

Conversation

KaiKosch
Copy link
Contributor

@KaiKosch KaiKosch commented Mar 21, 2025 •
edited
Loading

Description

  • Aligned the samples binary/protobuf/string/capnproto/flatbuffers
  • Changed the names of the .cpp files and source directories
  • Edited the CMakeList.txt files
  • Removed the tcp/upd samples

@Peguen Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Mar 21, 2025
@hannemn hannemn marked this pull request as ready for review March 26, 2025 09:31
hannemn
hannemn requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@hannemn hannemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, thank you. :-)

@KaiKosch KaiKosch requested a review from hannemn March 26, 2025 12:09
@hannemn hannemn merged commit e2ffed6 into eclipse-ecal:master Mar 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannemn hannemn hannemn approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaiKosch @hannemn @Peguen