Exclude query parameters when caching authentication info #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherardi
force-pushed
the
authCache
branch
2 times, most recently
from
6ab0021 to
dc8d4e7
Compare
jansupol
reviewed
Jun 20, 2018
| @@ -247,7 +246,22 @@ public void filter(ClientRequestContext request, ClientResponseContext response) | |||
| } | |||
|
|
|||
| private String getCacheKey(ClientRequestContext request) { | |||
| return request.getUri().toString() + ":" + request.getMethod(); | |||
| URI requestUri = request.getUri(); | |||
There was a problem hiding this comment.
This method duplicates code from DigestAuthenticator#getCacheKey. Does it make sense to put the code to a new static method to a new utility AuthenticationUtil class in the package?
There was a problem hiding this comment.
Yes, asbolutely. Done.
agherardi
force-pushed
the
authCache
branch
2 times, most recently
from
e3d8d43 to
c74a9ac
Compare
Signed-off-by: agherardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of https://github.com/jersey/jersey/pull/3760