Patch Jersey version in Glassfish 5.1.0 for TCK #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I forgot to mention what the fix is about. The patched JAR file was built from Jersey 2.28 + the fix for eclipse-ee4j/jersey#3670. My first impression is that the build is much more reliable now. We have two test failures which are most likely other problem. I'll rerun the build a few times to make sure that the random failures described in the issue above are gone now. |
|
I can confirm that we have more green tests. So I'll merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adjusted our test script to replace one of the Jersey modules shipping with Eclipse Glassfish 5.1.0 with a patched version. Let see if this fixes some of the errors we get when running the TCK against Eclipse Glassfish 5.1.0.
Travis, please test! :-)