Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the vendor of all plugins to Eclipse LSP4E #1143

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

FlorianKroiss
Copy link
Contributor

@FlorianKroiss FlorianKroiss commented Nov 15, 2024

The vendor for org.eclipse.lsp4e.debug was missing. Some of the other plugins used Eclipse.org as vendor.

@FlorianKroiss
Copy link
Contributor Author

I noticed this while going through the list of installed plugins in the About dialog

Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment inline

Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment inline

@FlorianKroiss
Copy link
Contributor Author

I guess in that case, some of the other plugins also need to be changed to "Eclipse LSP4E"?
image
If so, I can fix that too

@mickaelistria
Copy link
Contributor

If so, I can fix that too

that would be welcome!

@FlorianKroiss
Copy link
Contributor Author

Ok, I will also fix the other plugins.

Maybe on an unrelated note: The rule mentioned in the handbook does not seem to be widely followed?
image

@mickaelistria
Copy link
Contributor

Ok, I will also fix the other plugins.

Thanks.

The rule mentioned in the handbook does not seem to be widely followed?

IIRC the recommendation used to be "Eclipse.org" something like ~12 years ago. And many projects didn't change, and new projects took those older projects as example repeating the same anti-pattern.
But it's not a big deal as long as no-one complains.

@FlorianKroiss FlorianKroiss changed the title Set vendor for org.eclipse.lsp4e.debug to Eclipse.org Set the vendor of all plugins to Eclipse LSP4E Nov 15, 2024
@mickaelistria mickaelistria merged commit 74c507f into eclipse-lsp4e:main Nov 15, 2024
6 checks passed
@mickaelistria
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants