Suggestion for an alternative implementation for Pull Request #439#461
Draft
Dr-Eckig wants to merge 15 commits intoeclipse-opendut:developmentfrom
Draft
Suggestion for an alternative implementation for Pull Request #439#461Dr-Eckig wants to merge 15 commits intoeclipse-opendut:developmentfrom
Dr-Eckig wants to merge 15 commits intoeclipse-opendut:developmentfrom
Conversation
Dr-Eckig
force-pushed
the
development
branch
2 times, most recently
from
8b90b87 to
1f77257
Compare
…ity to select text.
…tables (like `PeersOverview`, `ClustersOverview`, `SourcesOverview`, `TestsOverview`).
Dr-Eckig
force-pushed
the
development
branch
from
1f77257 to
ccbe524
Compare
…ing text in the `TestsOverview` by using an event listener, because the previous solution was not compatible with all browsers.
…hen selecting text (`block_row_click`) from `Row` to `TestsOverview`.
…overview tables (e. g. `PeersOverview`, `ClustersOverview`, ...) by an additional component for rows, called `OverviewTableRow` for easier usage.
…s to the `app.rs` and provided a `context` to get its value.
…ow` for easier usage of the component `OverviewTableRow` and to reduce code duplication.
…e `SourcesOverview` page.
…tive tracking context".
…on, anchor-element or input field.
…h represents a column in a row for better usage and readability of the `OverviewTable`s.
…he `OverviewTable` component.
…he `OverviewTable` component.
…g the `OverviewTable` component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testoverview, so its possible to compare both implementations (the initial implementation is located inClusterandPeeroverviews)web-sys = { version = "0.3.85", features = ["Selection"] }Improvement
Goal