Skip to content

Conversation

JervenBolleman
Copy link
Contributor

@JervenBolleman JervenBolleman commented Nov 26, 2023

Junit4 is still used in a few places, one for lucene or guavatestlibs that don't have an junit4 equivalent

GitHub issue resolved: #4544

Briefly describe the changes proposed in this PR:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run   \ -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE   \
-Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit4to5Migration

Then reverting any module with compiler issues and throwing away all pom changes.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

…w places, one for lucene or guavatestlibs that don't have an junit4 equivalent

Signed-off-by: Jerven Bolleman <[email protected]>
@JervenBolleman JervenBolleman self-assigned this Nov 26, 2023
@JervenBolleman JervenBolleman added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Nov 26, 2023
@JervenBolleman JervenBolleman added this to the 5.0.0 milestone Nov 26, 2023
@hmottestad hmottestad modified the milestones: 5.0.0, 5.1.0 Jun 20, 2024
@JervenBolleman JervenBolleman marked this pull request as draft June 25, 2024 11:27
@hmottestad hmottestad modified the milestones: 5.1.0, 5.2.0 Nov 21, 2024
@hmottestad hmottestad removed this from the 5.2.0 milestone Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants