GH-5327 Add Support for RDF 1.2 Literals - JSON datatype and Language Base Direction #5389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Håvard Ottestad <[email protected]>
Signed-off-by: Håvard Ottestad <[email protected]>
Signed-off-by: Håvard Ottestad <[email protected]>
odysa
reviewed
Jul 30, 2025
core/rio/nquads/src/test/java/org/eclipse/rdf4j/rio/nquads/AbstractNQuadsWriterTest.java
Outdated
Show resolved
Hide resolved
core/rio/trig/src/test/java/org/eclipse/rdf4j/rio/trig/AbstractTriGWriterTest.java
Outdated
Show resolved
Hide resolved
core/rio/api/src/main/java/org/eclipse/rdf4j/rio/LanguageHandler.java
Outdated
Show resolved
Hide resolved
core/rio/api/src/test/java/org/eclipse/rdf4j/rio/AbstractParserTest.java
Outdated
Show resolved
Hide resolved
|
@SarahGrand BTW, we should squash your commits. |
odysa
reviewed
Aug 1, 2025
core/model/src/main/java/org/eclipse/rdf4j/model/impl/SimpleLiteral.java
Outdated
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/model-api/src/main/java/org/eclipse/rdf4j/model/base/AbstractLiteral.java
Outdated
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/model-api/src/main/java/org/eclipse/rdf4j/model/base/AbstractValueFactory.java
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/model-api/src/main/java/org/eclipse/rdf4j/model/base/AbstractValueFactory.java
Outdated
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/rio/api/src/main/java/org/eclipse/rdf4j/rio/helpers/RDFParserHelper.java
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/model-api/src/main/java/org/eclipse/rdf4j/model/Literal.java
Outdated
Show resolved
Hide resolved
odysa
reviewed
Aug 1, 2025
core/rio/languages/src/main/java/org/eclipse/rdf4j/rio/languages/RFC3066LanguageHandler.java
Outdated
Show resolved
Hide resolved
SarahGrand
force-pushed
the
GH-5327-rdf12
branch
from
ff8c411 to
fdd4b7f
Compare
odysa
reviewed
Aug 1, 2025
| private final BaseDirection baseDirection; | ||
|
|
||
| TaggedLiteral(String label, String language) { | ||
| this(label, language, null); |
There was a problem hiding this comment.
this(label, language, BaseDirection.NONE);
|
I've completed my review. Let me know your thoughts when you get a chance. |
SarahGrand
force-pushed
the
GH-5327-rdf12
branch
from
fdd4b7f to
4f69381
Compare
|
Unless you've modified any of the pom.xml files then you don't need worry about the license checks, they routinely fail. |
SarahGrand
force-pushed
the
GH-5327-rdf12
branch
2 times, most recently
from
d93bdb3 to
4f69381
Compare
SarahGrand
force-pushed
the
GH-5327-rdf12
branch
from
341ae94 to
d1e25c4
Compare
kenwenzel
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5327
Briefly describe the changes proposed in this PR:
Added support for
rdf:JSONdatatype.Added support for dirLangString literals. Added
dirLangStringdatatype, and the base direction itself is stored within the language string in Literal implementations. Supported in parsers and writers for Turtle, TriG, NTriples, and NQuads.Cleaned up parser testing code and put common functionality in AbstractParserTest.
Note: SPARQL functions for language direction (
hasLANGDIRandLANGDIR) not implemented.PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)