Add S-CORE quality maintenance proposal#389
Draft
Komal362000 wants to merge 2 commits into
Draft
Conversation
Komal362000
force-pushed
the
koma_task_quality_maintenance_score
branch
from
fc5e656 to
966878e
Compare
ahmed0mousa
reviewed
May 7, 2026
|
|
||
| **Proposed Model:** | ||
| - **PR checks (fast):** Build, unit tests, formatting, and basic lint. | ||
| - **Nightly checks (full):** CodeQL, full clang-tidy, sanitizers, coverage, and static analysis. |
Contributor
There was a problem hiding this comment.
In case we got some findings, When do you think we should fix it? Do we fix it immediately or When?
ahmed0mousa
reviewed
May 7, 2026
| - Show results in a **shared quality dashboard** so everyone can track quality. | ||
|
|
||
| **Proposed Model:** | ||
| - **PR checks (fast):** Build, unit tests, formatting, and basic lint. |
Contributor
There was a problem hiding this comment.
What about having quality jobs (CodeQL, Clang-tidy, Coverage) on every PR but it got triggered (manually) only once after the review process is done so we don't need to run quality jobs after each commit on the same time we are sure that no PRs introduce new findings?
ahmed0mousa
reviewed
May 7, 2026
|
|
||
| --- | ||
|
|
||
| ## Pros |
Contributor
There was a problem hiding this comment.
under which option are then pros cons ?!
ahmed0mousa
reviewed
May 7, 2026
|
|
||
| ### Option 2: CI Enforcement | ||
|
|
||
| In this model, quality gates are enforced directly in the CI pipeline. If code does not meet the agreed thresholds, the build or merge process fails. |
Contributor
There was a problem hiding this comment.
Did you check How much time it cost to run (CodeQL, Clang-tidy, Coverage) ? What is the average time for each job?
Komal362000
force-pushed
the
koma_task_quality_maintenance_score
branch
3 times, most recently
from
ad787a2 to
5bd322a
Compare
Komal362000
force-pushed
the
koma_task_quality_maintenance_score
branch
from
5bd322a to
4fafd59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.