Add get and set and notification support to the fields in the configuration#405
Open
sahithi-nukala wants to merge 7 commits into
Conversation
sahithi-nukala
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
- Introduce dedicated LolaFieldInstanceDeployment class replacing the former LolaEventInstanceDeployment type alias, adding field-specific members use_get_if_available_ and use_set_if_available_. - Fix mw_com_config_schema.json: move useGetIfAvailable and useSetIfAvailable into the field "properties" object so they are correctly validated when additionalProperties is false. Issue: SWP-250429
- Update config_parser.cpp to read optional field values useGetIfAvailable/useSetIfAvailable - Fix existing unit test of loloa field instance deployment. Issue: SWP-250429
Update existing tests which refer LolaFieldInstanceDeployment to support additional optional useGetIfAvailable and useSetIfAvailable Issue: SWP-250429
- Add tests to verfiy behaviour of option field values useGetIfAvailable/useSetIfAvailable Issue: SWP-250429
- Update ReadMe and UML diagram to refelct updated changes optional field values useGetIfAvailable/useSetIfAvailable Issue: SWP-250429
- Remove the redundant unit tests and update the exsiting test for default field setter/getter value - Update the default values of useGetIfAvailable/useSetIfAvailable from default false to true - Update the plant UML diagram to retain only necessary information Issue: SWP-250429
sahithi-nukala
force-pushed
the
suya_Add_get_and_set_and_notification_support_to_the_fields_in_the_configuration
branch
from
abae673 to
65d3943
Compare
… LolaEventInstanceDeployment members - Delegate GetNumberOfSampleSlots(), GetNumberOfTracingSlots(), and SetNumberOfSampleSlots() to the inner lola_event_instance_deployment_ member - Delegate CreateFromJson() event parsing and Serialize() event part to LolaEventInstanceDeployment - Add a non-template GetSkeletonEventProperties() overload in skeleton_service_element_binding_factory_impl.h that delegates to the event deployment overload - Update all call sites: config_parser.cpp, configuration_test_resources.cpp, and all affected test files
sahithi-nukala
force-pushed
the
suya_Add_get_and_set_and_notification_support_to_the_fields_in_the_configuration
branch
from
65d3943 to
7c3e519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add useGetIfAvailable/useSetIfAvailable to LoLa field deployment
Issue: SWP-250429