Skip to content

Extend GenericSkeletonEvent to trigger EventUpdate notification#409

Draft
Rahul-Sutariya wants to merge 1 commit into
eclipse-score:mainfrom
Rahul-Sutariya:extend_genericSkeletonEvent_to_trigger_eventUpdate_notification
Draft

Extend GenericSkeletonEvent to trigger EventUpdate notification#409
Rahul-Sutariya wants to merge 1 commit into
eclipse-score:mainfrom
Rahul-Sutariya:extend_genericSkeletonEvent_to_trigger_eventUpdate_notification

Conversation

@Rahul-Sutariya
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread score/mw/com/impl/bindings/lola/generic_skeleton_event_test.cpp Outdated
// Test: Construction
TEST_F(GenericSkeletonEventFixture, CanConstructAGenericSkeletonEvent)
{
RecordProperty("Verifies", "SCR-14035184");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st: I much appreciate, that you now did invest in all these missing unit-tests for GenericSkeletonEvent! GOOD!
The issue with the "linked" requirements (like SCR-14035184) is: These are IDs from the BMW internal codebeamer requirement system. They aren't visible in S-CORE, where we are now working. So we should rather link to the new requirements... see here: https://github.com/eclipse-score/communication/blob/main/score/mw/com/dependability/requirements/component_requirements/component_requirements_ipc.trlc#L1487
This is the same req. in its new form (in the broken link comment you see the relation to the old codebeamer req.)
So - please get in contact with Jochen Hoenle and ask him, how you should proceed (what you should link to in your test -> i.e. if instead of writing SCR-14035184 you should write ScoreReq.CompReq GenericProxyEventGetSampleSize

Comment thread score/mw/com/impl/bindings/lola/generic_skeleton_event_test.cpp Outdated
Comment thread score/mw/com/impl/bindings/lola/generic_skeleton_event_test.cpp
@Rahul-Sutariya Rahul-Sutariya force-pushed the extend_genericSkeletonEvent_to_trigger_eventUpdate_notification branch from e0be480 to 3a8e068 Compare May 15, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants