Skip to content

pastey crate safety qualification#31

Merged
aschemmel-tech merged 5 commits into
eclipse-score:mainfrom
bharatGoswami8:pastey_crate_certification
May 12, 2026
Merged

pastey crate safety qualification#31
aschemmel-tech merged 5 commits into
eclipse-score:mainfrom
bharatGoswami8:pastey_crate_certification

Conversation

@bharatGoswami8
Copy link
Copy Markdown
Contributor

@bharatGoswami8 bharatGoswami8 commented Apr 13, 2026

Added Safety analysis based on the Assessment References document: https://eclipse-score.github.io/process_description/main/folder_templates/modules/module_name/component_name/docs/component_classification.html

Code coverage for pastey crate is achieved 100% for line and branch.

Screenshot from 2026-05-06 11-53-27

Requirement PR -
#33

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 6 times, most recently from c356098 to b35021f Compare April 13, 2026 12:34
@bharatGoswami8 bharatGoswami8 self-assigned this Apr 13, 2026
@bharatGoswami8 bharatGoswami8 changed the title Pastey crate Safety certification Pastey crate safety qualification Apr 13, 2026
@bharatGoswami8 bharatGoswami8 changed the title Pastey crate safety qualification pastey crate safety qualification Apr 13, 2026
@bharatGoswami8 bharatGoswami8 marked this pull request as ready for review April 13, 2026 12:55
@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 2 times, most recently from 396408b to 069fc35 Compare April 15, 2026 05:15
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
@aschemmel-tech
Copy link
Copy Markdown
Contributor

aschemmel-tech commented Apr 15, 2026

Based on the classification I will set up a safety plan for this component in a separate PR

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 5 times, most recently from 79e0f02 to 9c060e3 Compare April 16, 2026 03:49
@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 3 times, most recently from ce65197 to 8d14e94 Compare April 16, 2026 04:11
@bharatGoswami8
Copy link
Copy Markdown
Contributor Author

@aschemmel-tech , Update qualification matrix report based on shared template, could you please review.

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most findings resolved, some additional ones found

Comment thread docs/pastey/docs/component_classification.rst Outdated
Comment thread external_crate_safety_qualification/pastey/result.rst Outdated
Comment thread docs/pastey/docs/component_classification.rst
Comment thread docs/pastey/docs/component_classification.rst Outdated
@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 2 times, most recently from 9751c4d to b565fc8 Compare April 20, 2026 05:31
@bharatGoswami8
Copy link
Copy Markdown
Contributor Author

@aschemmel-tech , Addressed the requested changes.

Copy link
Copy Markdown
Contributor

@darkwisebear darkwisebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should check in zip files. There is no reason as coverage data should be reproducible, so users could simply obtain them if needed.

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch from b565fc8 to 634103a Compare April 23, 2026 06:58
@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch 2 times, most recently from 9975f28 to 11bcfda Compare May 7, 2026 08:26
@bharatGoswami8
Copy link
Copy Markdown
Contributor Author

Hi @aschemmel-tech , @darkwisebear ,
I have updated requirement for pastry crate with this PR, could you please review.

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch from 11bcfda to aac2575 Compare May 11, 2026 05:51
@bharatGoswami8
Copy link
Copy Markdown
Contributor Author

Hi @aschemmel-tech , @darkwisebear ,

Requirement moved in separate PR - #33

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last topic is still open

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch from aac2575 to 4b21f94 Compare May 11, 2026 06:41
aschemmel-tech
aschemmel-tech previously approved these changes May 11, 2026
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now resolved the last one

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still ok

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

* - 2
- Are requirements available?
- PE
- Requirement specification is available in score-crates repository, in the form of trlc.
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not describe what will be the case in the future but the actual state of the crate (as it is provided Open Source).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted back to the currently available upstream data.

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch from fcbb36a to ab19bf9 Compare May 11, 2026 08:07
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bharatGoswami8 bharatGoswami8 force-pushed the pastey_crate_certification branch from ab19bf9 to b22dbcd Compare May 12, 2026 06:40
@aschemmel-tech aschemmel-tech merged commit 12da11c into eclipse-score:main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants