WIP: improve onboarding documentation#2874
Conversation
|
|
f3d1407 to
c0ddd6e
Compare
|
The created documentation from the pull request is available at: docu-html |
c0ddd6e to
854c668
Compare
PandaeDo
left a comment
There was a problem hiding this comment.
Some small comments from my side. Improvement of the onboarding is very helpful!
| * ******************************************************************************* | ||
| * | ||
| * Overrides the default purple S-CORE secondary color (#2D1942). | ||
| * --pst-color-secondary is used for the page header, card headers, table hover, etc. |
There was a problem hiding this comment.
I don't know where. But it seems to me that the handbook is not correctly integrated into the page. I have a purple line in between Eclipse S-CORE and Features. Also under that after the home symbol i have . And the only way to reach the slides is the navigation on the right sight. Maybe only rendered wrong on my side. So please check it.
There was a problem hiding this comment.
Same here, can not see any more entry point for handbook
| ^^^ | ||
| Our release roadmap can be found under :ref:`releases`. | ||
| Including an overview about integrated software modules and their repository location. | ||
| Check out our `latest release <https://eclipse-score.github.io/reference_integration/main/_collections/score_platform/docs/score_releases/score_releases/score_v0_6.html>`_ |
There was a problem hiding this comment.
If you use this link it will allways have the latest version on top https://github.com/eclipse-score/reference_integration/releases. Or if you want to show the html format https://eclipse-score.github.io/reference_integration/main/.
| and without direct customer value — S-CORE provides a common foundation with: | ||
|
|
||
| - **A reference implementation** that catches integration issues early and prevents known bugs from reappearing across projects. | ||
| - **A Functional-Safety-compliant process** (ISO 26262) applied to all modules, making S-CORE unique among open-source automotive projects. |
There was a problem hiding this comment.
I think it's not 100% when we say it will be applied to all modules. You might change it in a way that S-CORE includes a process based on ISO 26262 SEooC approach that is "ready the be certifiable" and it will applied by all modules that will contain in 1.0 release.
20e92be to
00bf575
Compare
00bf575 to
4485970
Compare
9c0d235 to
82bc924
Compare
masc2023
left a comment
There was a problem hiding this comment.
Overview is still missing in the Start/Landing Page, only available as card, but not top level entry
There was a problem hiding this comment.
System verification -> Platform or SW Platform Verification
There was a problem hiding this comment.
Thanks a lot for the overview.
I would suggest the following improvements:
- Unit Verification
- Please add Rust Test as an alternative
- Component / Feature Verification
- Please add GoogleTest and Rust Test as an alternative.
In case the component is a library this should be sufficient for most test cases. For non-functional tests and later security tests ITF will probably get mandatory
- Please add GoogleTest and Rust Test as an alternative.
- Feature Verification
- Please remove (ITF) from blue box.
| --pst-color-text-base: #ffffff; | ||
| --pst-color-link: #ffffff; | ||
| --pst-color-link-hover: #ffffff; | ||
| color: #ffffff !important; |
There was a problem hiding this comment.
!important is bad practise as it destroys the layout
576cf94 to
a2d81ae
Compare
a2d81ae to
3ddd051
Compare
|
|
||
| Please note that the Eclipse S-CORE´s software architecture is continuously refined and will evolve in future releases. | ||
|
|
||
| .. image:: ../../modules/_assets/module_architecture.drawio.svg |
There was a problem hiding this comment.
we have different mismatching architectural views: https://eclipse-score.github.io/score/pr-2874/_images/architecture_0_6.drawio.svg and the used link https://eclipse-score.github.io/score/pr-2874/_images/module_architecture.drawio.svg
a) we have to consolidate
b) for the purpose here, I would suggest to use the building block architectural view as in https://eclipse-score.github.io/score/pr-2874/_images/architecture_0_6.drawio.svg
| html body .score-grid .sd-card .sd-card-body a:hover, | ||
| html body .score-grid .sd-card .sd-card-body a:visited, | ||
| html body .score-grid .sd-card .sd-card-body * { | ||
| color: #ffffff !important; |
There was a problem hiding this comment.
layout rules shall not be overwritten
There was a problem hiding this comment.
only cpp covered?
approval comments help, but 2nd source to process description: double maintenance issue!
There was a problem hiding this comment.
do we really follow the module=one repository approach?
| @@ -169,13 +173,14 @@ Here, we´re making the first declaration of our module by defining a name and a | |||
| Please be aware, that only after our module was published in the Eclipse S-CORE bazel registry, other modules can access it. | |||
|
|
|||
| Rename the module and replace *cpp_rust_template_repository* by *score_scrample*. | |||
There was a problem hiding this comment.
score/<module_name instead scrample ?
| .. | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2024 Contributors to the Eclipse Foundation | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
do not replace copyright year in existing files. The year shall represent file creation (or last full rewrite)
|
|
||
|
|
||
| def setup(app): | ||
| app.add_css_file("css/score.css", priority=600) |
There was a problem hiding this comment.
Introducing a new style file means we need someone to maintain it, as new docs-as-code versions can easily be incompatible. score repo is notoriously unmaintained.
No description provided.