Skip to content

[Sskz] fix filling of column B#1251

Merged
TruongQuangSB merged 9 commits intomainfrom
sskz-fix-column-b-filling
Jan 15, 2025
Merged

[Sskz] fix filling of column B#1251
TruongQuangSB merged 9 commits intomainfrom
sskz-fix-column-b-filling

Conversation

@mariusheine
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

Test Results

121 tests   121 ✅  18s ⏱️
 28 suites    0 💤
 28 files      0 ❌

Results for commit c23342f.

♻️ This comment has been updated with latest results.

.map(c -> c.filling.apply(element))
.flatMap(it -> StreamSupport
.stream(it.spliterator(), false))
.collect(Collectors.toList()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList()),
.toList(),

From Stream can direct toList() 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TruongQuangSB I changedit

schluessel.getIDStellelement().getValue());
case final Stellelement stellement -> List
.of(stellement.getIDInformation().getValue());
default -> null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TruongQuangSB No it was not intentional. The autoformatter changed it... I will revert it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TruongQuangSB Puhh that was ahrd to reset 🤣 Damn eclipse autoformatter. But now it is as before

@github-actions

This comment has been minimized.

@github-actions
Copy link

License summary

⚠️ Failed to process DEPENDENCIES.

  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/12785723391

@github-actions
Copy link

License summary

⚠️ Failed to process DEPENDENCIES.

  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/12785701149

@github-actions
Copy link

License summary

⚠️ Failed to process DEPENDENCIES.

  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/12785690724

@TruongQuangSB
Copy link
Contributor

/license-check

@github-actions
Copy link

License summary

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-set/set/actions/runs/12785841317

@TruongQuangSB TruongQuangSB merged commit 2969597 into main Jan 15, 2025
9 of 11 checks passed
@TruongQuangSB TruongQuangSB deleted the sskz-fix-column-b-filling branch January 15, 2025 10:07
TruongQuangSB pushed a commit to SuB-PlanPro/set that referenced this pull request Jan 16, 2025
* evaluate all cases for sskz column B and combine them

* revert formatting

* revert formatting

* revert formatting

* revert formatting

* revert formatting

* revert formatting

* revert formatting

* easify expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants