[41] Use EMF's intrinsicIDToEObjectMap if present #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit (1f44029) completely disabled EMF's default getEObjectByID in favor of using our own JSONResourceImpl-specific id map. However there are cases where we still want to lookup elements by their intrinsic (modeled) id instead of the IDManager-provided one, without incurring the cost of an eAllContents() on failure. This change allows for this to work, as long as the JSONResourceImpl has been setup with a non-null intrinsicIDToEObjectMap. For example right after the resource creation: ((ResourceImpl) resource).setIntrinsicIDToEObjectMap(new HashMap<>()); Once this is done, any new object added to the resource will get its intrinsic id cached in this map (see ResourceImpl.attachedHelper()) and JsonResourceImpl.getEObjectById will find it there (if present) while still bypassing the whole eAllContents() search in super.getEObjectByID(id). Bug: #41 Signed-off-by: Pierre-Charles David <[email protected]>
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit (1f44029) completely disabled EMF's default
getEObjectByIDin favor of using our ownJSONResourceImpl-specific id map. However there are cases where we still want to lookup elements by their intrinsic (modeled) id instead of theIDManager-provided one, without incurring the cost of an eAllContents() on failure.This change allows for this to work, as long as the
JSONResourceImplhas been setup with a non-nullintrinsicIDToEObjectMap. For example right after the resource creation:Once this is done, any new object added to the resource will get its intrinsic id cached in this map (see
ResourceImpl.attachedHelper()) andJsonResourceImpl.getEObjectByIdwill find it there (if present) while still bypassing the wholeeAllContents()search insuper.getEObjectByID(id).Bug: #41