DNM Add flatpak manifest: offline theia build
not working
#390
+24,964
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a flatpak manifest.
It is not meant for inclusion here but rather meant to help fix remaining issues with this way of building theia-ide in an offline-manner.
Eventually, my plan is to create a dedicated repo for this on Flathub.
Related to: #360
I'm running into two distinct issues with the offline building of theia-ide as required for flatpaks.
I'll focus on the building of the electron app for now as that's what's going to be needed for the flatpak container.
This specific issues arises here when
theia build --app-target="electron"
is invoked (theyarn -s rebuild
beforehand finishes successfully).theia build
is trying to call out to github and we can't have that in an offline build. If anyone could help solve this I'd highly appreciate it.