Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo appearing on the front page #571

Closed
wants to merge 1 commit into from
Closed

Fix a typo appearing on the front page #571

wants to merge 1 commit into from

Conversation

kurtmckee
Copy link

- availabe
+ available

Copy link

github-actions bot commented Jul 1, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-01 16:31 UTC

@JonasHelming
Copy link
Contributor

@kurtmckee Thank you for the fix! In order to accept it, could you sign the ECA (https://api.eclipse.org/git/eca/status/gh/eclipse-theia/theia-website/571)
This is a one time thing. Sorry for the overhead, especially because this is really just a type correction. However, we take IP due dilligence seriously. Once the ECA is signed once, it is valid for all future contributions

@kurtmckee
Copy link
Author

Looks like I have to provide a lot of personal information, like my name as it appears on my passport.

No.

@kurtmckee kurtmckee closed this Jul 1, 2024
@kurtmckee kurtmckee deleted the fix-typo branch July 1, 2024 16:31
@kurtmckee
Copy link
Author

To be clear: I understand that it's required, but am not willing to provide the required information.

The fact that I posted this PR doesn't give me exclusive rights to the fix -- feel free to fix the typo independently. 👍

JonasHelming added a commit that referenced this pull request Jul 1, 2024
fixed #571

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming mentioned this pull request Jul 1, 2024
@JonasHelming
Copy link
Contributor

Got you! see #573

Thank you very much for reporting this and taking the effort to contribute a fix!

JonasHelming added a commit that referenced this pull request Jul 2, 2024
fixed #571

Signed-off-by: Jonas Helming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants