Allow specifying max lines used for AI code completion context#14539
Merged
JonasHelming merged 3 commits intomasterfrom Nov 28, 2024
Merged
Allow specifying max lines used for AI code completion context#14539JonasHelming merged 3 commits intomasterfrom
JonasHelming merged 3 commits intomasterfrom
Conversation
Contributor
martin-fleck-at
left a comment
martin-fleck-at
left a comment
There was a problem hiding this comment.
The change looks good to me and works as expected. Thank you very much, Jonas! However, I do have some questions regarding the setting as a whole that I'd like to clarify before we merge this.
fixed #14538 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Make suffix calculation robust against beeing at line 0 Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming
force-pushed
the
GH-14538
branch
from
dd8a33d to
dec8d73
Compare
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
martin-fleck-at
approved these changes
Nov 28, 2024
Contributor
martin-fleck-at
left a comment
martin-fleck-at
left a comment
There was a problem hiding this comment.
I had another look and everything works really nicely! Thank you very much for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review #14537 first, please
What it does
Adds a new user setting allowing to specify max lines used for AI code completion context
How to test
Follow-ups
This could be more sophisticated, e.g. with percentages for prefix and suffix or by respecting the AST.
Review checklist
Reminder for reviewers