Show more dev container info in title bar #14571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jonah-iden
requested changes
Dec 4, 2024
packages/dev-container/src/electron-browser/container-info-contribution.ts
Outdated
Show resolved
Hide resolved
jbicker
force-pushed
the
jbicker/containerinfo-in-title
branch
2 times, most recently
from
0a0f27c to
ebd823e
Compare
msujew
reviewed
Dec 9, 2024
| @@ -95,6 +103,10 @@ export class WindowTitleService { | |||
| } | |||
| const separatedTitle = title.split('${separator}').filter(e => e.trim().length > 0); | |||
| this._title = separatedTitle.join(this.separator); | |||
| const contributions = this.titleContributions.getContributions(); | |||
There was a problem hiding this comment.
Question: Can we use this feature to also implement the developmentHost part of this method? I wasn't happy with the initial implementation anyway, and this looks like a good way of cleaning up the feature.
There was a problem hiding this comment.
I'll do that in another PR
jbicker
force-pushed
the
jbicker/containerinfo-in-title
branch
from
ebd823e to
42545d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds info to window title when workspace is loaded in Dev Container and which platform the container is running on.
How to test
Start a Dev Container and look up onto the title. There should additionally be something like
[Dev Container @ linux]Breaking changes
Attribution
Review checklist
Reminder for reviewers