Add jump to cursor #14594
Add jump to cursor #14594
Conversation
Extend context menu of editor with jump to cursor option. Extend context menu of editor margin with jump to cursor option. The option is visible only during the debugging session and if the debug adapter supports this. Fixes issue eclipse-theia#14500 Signed-off-by: Nandish Mahadevaiah <[email protected]>
There was a problem hiding this comment.
Thank you @mahadevaiahn for this contribution!
This already looks quite good, I just have a few suggestions to improve on this.
| export const JUMP_TO_CURSOR = Command.toDefaultLocalizedCommand({ | ||
| id: 'editor.debug.action.jumpToCursor', | ||
| label: 'Debug: Jump to Cursor' | ||
| }); |
There was a problem hiding this comment.
Suggestion: We usually split the label from the category. I'm not sure why this isn't done for the SHOW_HOVER command.
| export const JUMP_TO_CURSOR = Command.toDefaultLocalizedCommand({ | |
| id: 'editor.debug.action.jumpToCursor', | |
| label: 'Debug: Jump to Cursor' | |
| }); | |
| export const JUMP_TO_CURSOR = Command.toDefaultLocalizedCommand({ | |
| id: 'editor.debug.action.jumpToCursor', | |
| category: DEBUG_CATEGORY, | |
| label: 'Jump to Cursor' | |
| }); |
| const response: DebugProtocol.GotoTargetsResponse = await this.session.sendRequest('gotoTargets', { source, line: position.lineNumber, column: position.column }); | ||
|
|
||
| if (response && response.body.targets.length === 0) { | ||
| throw new Error('Unable to perform Jump to Cursor as there were no targets'); |
There was a problem hiding this comment.
Suggestion: This error should likely not be thrown, but instead result in undefined and a warning in the notifications service. See the original implementation in vscode.
| if (response && response.body.targets.length === 0) { | ||
| throw new Error('Unable to perform Jump to Cursor as there were no targets'); | ||
| } | ||
| const targetId = response.body.targets[0].id; |
There was a problem hiding this comment.
Suggestion: It would be great if you could implement a "choose the location" quick pick like it's done in vscode in case there are multiple targets.
There was a problem hiding this comment.
Hi @msujew , many thanks for your review, I could not find a debugger which supported multiple targets, as I could not test this feature, I decided not to implement the QuickInputService.pick here.
|
|
||
|
|
There was a problem hiding this comment.
Formatting: Please remove the added lines here, they will lead to linting errors.
msujew
added
vscode
…ew changes. Signed-off-by: nandish mahadevaiah <[email protected]>
Signed-off-by: nandish mahadevaiah <[email protected]>
What it does
Extend context menu of editor with jump to cursor option. Extend context menu of editor margin with jump to cursor option. The option is visible only during the debugging session and if the debug adapter supports this.
Closes #14500
How to test
a=1
b=2
c=3
d=4
Follow-ups
Breaking changes
Attribution
Contributed by MVTec Software GmbH
Review checklist
Reminder for reviewers