Skip to content

Fix for #14615: "Collapse Side Panel" tab bar context menu item is enabled even when panel is collapsed#14616

Merged
martin-fleck-at merged 1 commit intoeclipse-theia:masterfrom
sophiali23:disable-collapse-side-panel-context-menu-item-when-panel-collapsed
Dec 12, 2024
Merged

Fix for #14615: "Collapse Side Panel" tab bar context menu item is enabled even when panel is collapsed#14616
martin-fleck-at merged 1 commit intoeclipse-theia:masterfrom
sophiali23:disable-collapse-side-panel-context-menu-item-when-panel-collapsed

Conversation

@sophiali23
Copy link
Copy Markdown
Contributor

What it does

Fixes #14615. "Collapse Side Panel" tab bar context menu item is enabled even when side panel is collapsed. My fix will disable the context menu item if the panel is not expanded.

How to test

  1. Expand left panel.
  2. Right-click on the tab bar to open context menu.
  3. Observe "Collapse Side Panel" menu item is enabled. Click this item to collapse panel.
  4. Right-click on the tab bar again.
  5. Observe "Collapse Side Panel" menu item is disabled.
  6. Repeat steps 1-5 for the right panel.

Attribution

Contributed on behalf of Texas Instruments

Review checklist

Reminder for reviewers

Copy link
Copy Markdown
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sophiali23, great catch! I reviewed your change and it works perfectly. Thank you for your contribution - it truly helps improve the overall user experience, highly appreciated!

@martin-fleck-at martin-fleck-at merged commit 60cbc71 into eclipse-theia:master Dec 12, 2024
@github-actions github-actions Bot added this to the 1.57.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

"Collapse Side Panel" context menu item is enabled and visible even when panel is collapsed

2 participants